Skip to content

Conversation

C-Hess
Copy link
Contributor

@C-Hess C-Hess commented Mar 9, 2020

Originally, when dropdownMatchSelectWidth is not provided and the width of the dropdown is larger than the width of the Select input, the dropdown will overflow instead of adjusting position automatically. This change checks dropdownMatchSelectWidth changes the dropdown placement overflow.adjustX accordingly

Before:

image

After:

image

@vercel
Copy link

vercel bot commented Mar 9, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/select/qixpuerv4
✅ Preview: https://select-git-fork-c-hess-pr-auto-adjust-x.react-component.now.sh

@zombieJ
Copy link
Member

zombieJ commented Mar 10, 2020

Nice work! Could you help add an useMemo to cache the builtinPlacements prop?

@zombieJ zombieJ merged commit 57148ff into react-component:master Mar 11, 2020
@zombieJ
Copy link
Member

zombieJ commented Mar 11, 2020

+ rc-select@10.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants