Skip to content

fix: input onChange fires with duplicated value when wrapped in select and using paste #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: input onChange fires with duplicated value when wrapped in select and using paste #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c87a8f9
fix: trigger search after input value onchanged
AlbertAZ1992 Jul 2, 2020
62dcd1a
feat: update select paste async test
AlbertAZ1992 Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Selector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,8 @@ const Selector: React.RefForwardingComponent<RefSelectorProps, SelectorProps> =
pasteClearRef.current = true;
setTimeout(() => {
pasteClearRef.current = false;
triggerOnSearch(value);
});

triggerOnSearch(value);
};

// ====================== Focus ======================
Expand Down
15 changes: 12 additions & 3 deletions tests/Tags.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ describe('Select.Tags', () => {
expectOpen(wrapper, false);
});

it('paste content to split', () => {
it('paste content to split after 100ms', done => {
jest.useFakeTimers();
const onChange = jest.fn();
const wrapper = mount(
<Select mode="tags" tokenSeparators={[' ', '\n']} onChange={onChange}>
Expand All @@ -160,8 +161,16 @@ describe('Select.Tags', () => {
target: { value: ' light bamboo ' },
});

expect(onChange).toHaveBeenCalledWith(['light', 'bamboo'], expect.anything());
expect(onChange).toHaveBeenCalledTimes(1);
setTimeout(() => {
try {
expect(onChange).toHaveBeenCalledWith(['light', 'bamboo'], expect.anything());
expect(onChange).toHaveBeenCalledTimes(1);
done();
} catch (err) {
done.fail(err);
}
}, 100);
jest.runTimersToTime(100);
});

it('renders unlisted item in value', () => {
Expand Down