Skip to content

Conversation

seonghyeonkimm
Copy link
Contributor

@seonghyeonkimm seonghyeonkimm commented Aug 3, 2020

Descriptions

  • When using mode=tags, it search values based on optionFilterProp value. However, Even If the option which has the same optionFilterProp value, mode=tags unshift new option to displayOptions.

Suggestion

  • For now, it checks values between option.value and mergedSearchValue to decide whether it unshift new option or not
  • I think that the condition should be changed to use optionFilterProp.

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/4u8o89zne
✅ Preview: https://select-git-fork-seonghyeonkimm-master.react-component.vercel.app

@seonghyeonkimm seonghyeonkimm changed the title Update Tags Mode to display options based on optionFilterProp [Enhancement] Update Tags Mode to display options based on optionFilterProp Aug 3, 2020
@seonghyeonkimm seonghyeonkimm changed the title [Enhancement] Update Tags Mode to display options based on optionFilterProp feat: Update Tags Mode to display options based on optionFilterProp Aug 3, 2020
@seonghyeonkimm seonghyeonkimm changed the title feat: Update Tags Mode to display options based on optionFilterProp feat: Update Tags Mode to display options matched with optionFilterProp Aug 3, 2020
@seonghyeonkimm
Copy link
Contributor Author

@zombieJ Could you review this PR whether this PR is appropriate or not?

@zombieJ zombieJ merged commit 23075d5 into react-component:master Aug 7, 2020
@zombieJ
Copy link
Member

zombieJ commented Aug 7, 2020

+ rc-select@11.1.3

@07akioni
Copy link
Contributor

fix ant-design/ant-design#25314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants