Skip to content

Conversation

headwindz
Copy link
Contributor

To support sorting functionality.

Issue Link

@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/b195oas7w
✅ Preview: https://select-git-featuresorter.react-component.vercel.app

@zombieJ
Copy link
Member

zombieJ commented Nov 2, 2020

Add filterSort instead sort & sortOrder. It's meaningless in top level since user always can sort their self by pass ordered options.

@zombieJ
Copy link
Member

zombieJ commented Nov 3, 2020

Strange. CI failed. Let me check why...

@zombieJ
Copy link
Member

zombieJ commented Nov 3, 2020

@n0rush rebase master~

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #558 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   99.26%   99.27%           
=======================================
  Files          20       20           
  Lines         957      961    +4     
  Branches      312      314    +2     
=======================================
+ Hits          950      954    +4     
  Misses          6        6           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.18% <100.00%> (+0.01%) ⬆️
src/generate.tsx 99.67% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0772dd...9ff9da7. Read the comment docs.

@zombieJ zombieJ merged commit 251a032 into react-component:master Nov 3, 2020
@zombieJ
Copy link
Member

zombieJ commented Nov 3, 2020

+ rc-select@11.5.0

Pls help to PR for antd feature branch : )

@headwindz headwindz deleted the feature_sorter branch November 10, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants