Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 14, 2020

动态测量依赖于元素尺寸,移除了节点动画。帮忙测测。另外,动态元素后,inline 对齐可能会有问题,之后如果用户有问题,就直接推荐用 Space。

https://select-git-responsive.react-component.vercel.app/?path=/story/rc-select--tags

第一个例子

(没问题再补测试)

@zombieJ zombieJ requested a review from afc163 December 14, 2020 03:36
@vercel
Copy link

vercel bot commented Dec 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/917st3v87
✅ Preview: https://select-git-responsive.react-component.vercel.app

@kerm1it
Copy link
Member

kerm1it commented Dec 15, 2020

image

null 的时候

@afc163
Copy link
Member

afc163 commented Dec 15, 2020

https://select-git-responsive.react-component.vercel.app/?path=/story/rc-select--tags

第一个例子是不是搞成宽度自适应,这样比较好测试。

@zombieJ
Copy link
Member Author

zombieJ commented Dec 15, 2020

改成 nowrap 遇到超长 suffix 就没办法折行了。

截屏2020-12-15 下午9 33 36

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #578 (98828b4) into master (12caa24) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files          20       20              
  Lines         967      962       -5     
  Branches      327      324       -3     
==========================================
- Hits          960      955       -5     
  Misses          6        6              
  Partials        1        1              
Impacted Files Coverage Δ
src/Selector/index.tsx 96.82% <ø> (ø)
src/generate.tsx 99.67% <ø> (ø)
src/interface/generator.ts 100.00% <ø> (ø)
src/Selector/MultipleSelector.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12caa24...98828b4. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Dec 23, 2020

准备发个大的 alpha 版本试试

@zombieJ zombieJ merged commit d374483 into master Dec 23, 2020
@zombieJ zombieJ deleted the responsive branch December 23, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants