Skip to content

fix: breakline of seprator #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

fix: breakline of seprator #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a5acef
fix: br logic
zombieJ Jan 27, 2021
17073e1
fix: Test case
zombieJ Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Selector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ const Selector: React.RefForwardingComponent<RefSelectorProps, SelectorProps> =
// Pasted text should replace back to origin content
if (tokenWithEnter && pastedTextRef.current && /[\r\n]/.test(pastedTextRef.current)) {
// CRLF will be treated as a single space for input element
const replacedText = pastedTextRef.current.replace(/\r\n/g, ' ').replace(/[\r\n]/g, ' ');
const replacedText = pastedTextRef.current
.replace(/[\r\n]+$/, '')
.replace(/\r\n/g, ' ')
.replace(/[\r\n]/g, ' ');
value = value.replace(replacedText, pastedTextRef.current);
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Tags.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('Select.Tags', () => {
{
tokenSeparators: ['\r\n'],
clipboardText: '\r\nlight\r\nbamboo\r\n',
inputValue: ' light bamboo ',
inputValue: ' light bamboo',
},
{
tokenSeparators: [' ', '\r\n'],
Expand All @@ -164,7 +164,7 @@ describe('Select.Tags', () => {
{
tokenSeparators: ['\n'],
clipboardText: '\nlight\nbamboo\n',
inputValue: ' light bamboo ',
inputValue: ' light bamboo',
},
].forEach(({ tokenSeparators, clipboardText, inputValue }) => {
it(`paste content to split (${JSON.stringify(tokenSeparators)})`, () => {
Expand Down