fix: 兼容 labelInValue 时 value 为 null 引起的报错 #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/3tgd7tsye |
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 20 20
Lines 967 971 +4
Branches 322 324 +2
=======================================
+ Hits 960 964 +4
Misses 6 6
Partials 1 1
Continue to review full report at Codecov.
|
xrkffgg
reviewed
Jan 30, 2021
| return finalVal; | ||
| }); | ||
| rawValues = (values as LabelValueType[]) | ||
| .filter(item => !!item) |
There was a problem hiding this comment.
value 为 0 时，也被 filter 了
labelInValue 模式下，需要支持这种非法数据格式么
afc163
added a commit
that referenced
this pull request
Apr 7, 2021
ceriverso
pushed a commit
to ceriverso/select-component
that referenced
this pull request
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.