Skip to content

Conversation

beichensky
Copy link
Contributor

fixed the problem of generating empty tags by pressing Enter when nothing was entered.

Link issue: <Select /> in tags mode renders empty tag after pressing enter

Solution: If the content is empty, return directly.

@vercel
Copy link

vercel bot commented Mar 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/6g8sYpbvUq7Nm14pPcGVDoUnEsuA
✅ Preview: https://select-git-fork-beichensky-fix-empty-tag-react-component.vercel.app

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #610 (4f763e2) into master (ff723eb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          20       20           
  Lines         972      974    +2     
  Branches      326      327    +1     
=======================================
+ Hits          964      966    +2     
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
src/generate.tsx 99.68% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff723eb...65c3c0c. Read the comment docs.

@afc163 afc163 merged commit d5018f5 into react-component:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants