Skip to content

Conversation

Alqanar
Copy link
Contributor

@Alqanar Alqanar commented Mar 18, 2021

Closes: #521
In our project we encountered a similar problem problem as described in issue 521
Снимок экрана 2021-03-18 в 14 30 35

In the PR I added a mobile check and a check if we have current in the selectorRef

@vercel
Copy link

vercel bot commented Mar 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/8NALNNBtKsJWM3BuBgQ9n3AWmoMh
✅ Preview: https://select-git-fork-alqanar-issue-521-focus-after-bl-6f3d2d.vercel.app

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #611 (a6a1200) into master (d5018f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a6a1200 differs from pull request most recent head 75b4340. Consider uploading reports for the commit 75b4340 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   99.17%   99.18%           
=======================================
  Files          20       20           
  Lines         974      977    +3     
  Branches      327      327           
=======================================
+ Hits          966      969    +3     
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
src/generate.tsx 99.68% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5018f5...75b4340. Read the comment docs.

@afc163 afc163 requested a review from zombieJ March 19, 2021 01:39
@zombieJ
Copy link
Member

zombieJ commented Mar 19, 2021

It's strange that in mobile popupElement contains always the active element menu. But I do not research so much on this. This fix seems ok to me.

@zombieJ zombieJ merged commit fd852fe into react-component:master Mar 19, 2021
@zombieJ
Copy link
Member

zombieJ commented Mar 19, 2021

+ rc-select@12.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select on mobile trigger focus after blur event was fired

2 participants