Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 24, 2021

感觉上游 rc-tree-select 还是需要锁一下版本,否则这种 breaking 改动不好处理。准备发个大版本之后全部锁 minor。

另外,和 @PeachScript 聊了一下 mono repo 改造成本略大,issue 和 PR 也需要迁移。可以走 git 子模块形式,但是需要自己搞一个版本依赖管理的东东。晚点我再研究研究。

ref ant-design/ant-design#24282

@vercel
Copy link

vercel bot commented Jun 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/FpkB2iTQY9KN3FbVj17xqHybAGLg
✅ Preview: https://select-git-fieldnames-react-component.vercel.app

@zombieJ zombieJ requested a review from afc163 June 24, 2021 03:39
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #641 (efcd434) into master (c314038) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   99.09%   99.10%   +0.01%     
==========================================
  Files          20       20              
  Lines         990     1003      +13     
  Branches      321      329       +8     
==========================================
+ Hits          981      994      +13     
  Misses          8        8              
  Partials        1        1              
Impacted Files Coverage Δ
src/generate.tsx 99.38% <ø> (ø)
src/interface/generator.ts 100.00% <ø> (ø)
src/OptionList.tsx 99.20% <100.00%> (+0.01%) ⬆️
src/hooks/useCacheOptions.ts 100.00% <100.00%> (ø)
src/utils/valueUtil.ts 100.00% <100.00%> (ø)
src/Selector/MultipleSelector.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c314038...efcd434. Read the comment docs.

@zombieJ zombieJ merged commit 0ec5fba into master Jun 24, 2021
@zombieJ zombieJ deleted the fieldNames branch June 24, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant