Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 8, 2021

将 Select 剥离为 Select 和 BaseSelect,其中 BaseSelect 仅做 Selector 和 SelectTrigger 相关逻辑。options 处理逻辑移至 Select 中。

@zombieJ zombieJ requested a review from afc163 December 8, 2021 14:25
@vercel
Copy link

vercel bot commented Dec 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/6M2fg2kW6yWK6y26kDbKQATFQsv1
✅ Preview: https://select-git-base-select-react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #685 (d221dc3) into master (1dab511) will increase coverage by 0.38%.
The diff coverage is 100.00%.

❗ Current head d221dc3 differs from pull request most recent head 71ca0cd. Consider uploading reports for the commit 71ca0cd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   99.11%   99.49%   +0.38%     
==========================================
  Files          20       24       +4     
  Lines        1017      996      -21     
  Branches      345      316      -29     
==========================================
- Hits         1008      991      -17     
+ Misses          8        4       -4     
  Partials        1        1              
Impacted Files Coverage Δ
src/SelectTrigger.tsx 100.00% <ø> (ø)
src/Selector/Input.tsx 100.00% <ø> (ø)
src/Selector/SingleSelector.tsx 100.00% <ø> (ø)
src/TransBtn.tsx 84.61% <ø> (ø)
src/utils/commonUtil.ts 100.00% <ø> (ø)
src/BaseSelect.tsx 100.00% <100.00%> (ø)
src/OptionList.tsx 99.29% <100.00%> (+0.03%) ⬆️
src/Select.tsx 100.00% <100.00%> (ø)
src/SelectContext.ts 100.00% <100.00%> (ø)
src/Selector/MultipleSelector.tsx 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dab511...71ca0cd. Read the comment docs.

@zombieJ zombieJ merged commit a77be9b into master Dec 9, 2021
@zombieJ zombieJ deleted the base-select branch December 9, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant