-
-
Notifications
You must be signed in to change notification settings - Fork 478
refactor: Move Select logic out of BaseSelect #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/6M2fg2kW6yWK6y26kDbKQATFQsv1 |
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
+ Coverage 99.11% 99.49% +0.38%
==========================================
Files 20 24 +4
Lines 1017 996 -21
Branches 345 316 -29
==========================================
- Hits 1008 991 -17
+ Misses 8 4 -4
Partials 1 1
Continue to review full report at Codecov.
|
将 Select 剥离为 Select 和 BaseSelect,其中 BaseSelect 仅做 Selector 和 SelectTrigger 相关逻辑。options 处理逻辑移至 Select 中。