Skip to content

Conversation

LongHaoo
Copy link
Contributor

fix the Ant Design-Issue #33281
What I do?

  1. add judgment when the select closed
  2. move the openSelect judgment to the keyUtils,
    • reason: Prevent the judgment logic from polluting components

我做了什么?

  1. 增加判断当选择框关闭的时候
  2. 将判断函数抽象移动至keyUtils
    • 原因:防止大量判断污染组件

@vercel
Copy link

vercel bot commented Dec 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/B1xZshi11oScVqhTUJjMFkc7qnFS
✅ Preview: https://select-git-fork-zzggitter-fix-keydown-erroropen-react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #693 (87ca89c) into master (cdb4f00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          24       25    +1     
  Lines        1009     1011    +2     
  Branches      320      320           
=======================================
+ Hits         1004     1006    +2     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/Selector/index.tsx 100.00% <100.00%> (ø)
src/utils/keyUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb4f00...87ca89c. Read the comment docs.

@zombieJ zombieJ merged commit f444f50 into react-component:master Dec 24, 2021
@zombieJ
Copy link
Member

zombieJ commented Dec 24, 2021

+ rc-select@14.0.0-alpha.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants