Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 19, 2022

ref:

发现是个远古 BUG,adjustX 为 0 希望如果超出就自动切换。但是在 dom-align 直接根据 adjustX 判断是否需要转向,因而 0 就被跳过了。绕了很远,直接 adjustX 默认 1 就能转了。

@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/8GwGwwwUXvNkKUX4oHdu4Thu6wYq
✅ Preview: https://select-git-auto-placement-react-component.vercel.app

@zombieJ zombieJ changed the title chore: auto dropdown placement fix: auto dropdown placement Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #710 (08c25cb) into master (14353d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files          25       25              
  Lines        1012     1009       -3     
  Branches      321      334      +13     
==========================================
- Hits         1007     1004       -3     
  Misses          4        4              
  Partials        1        1              
Impacted Files Coverage Δ
src/Select.tsx 100.00% <100.00%> (ø)
src/SelectTrigger.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14353d8...08c25cb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant