Skip to content

feat: fix js error if value not in options #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2022
Merged

feat: fix js error if value not in options #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1685d5
feat: fix js error if value not in options
Mar 11, 2022
1882d08
feat: 添加测试用例
Mar 13, 2022
1280d23
feat: 添加测试用例
Mar 13, 2022
ff05fb9
feat: 添加测试用例
Mar 14, 2022
26a68ff
feat: 添加测试用例
Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ const Select = React.forwardRef(
? {
label: option?.[mergedFieldNames.label],
value: val,
key: option.key ?? val,
key: option?.key ?? val,
}
: val,
injectPropsWithOption(option),
Expand Down
21 changes: 21 additions & 0 deletions tests/Multiple.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,27 @@ describe('Select.Multiple', () => {
expect(wrapper.exists('.rc-select-selection-item-remove')).toBeFalsy();
});

it('do not crash if value not in options when removing option', () => {
const wrapper = mount(
<Select
defaultValue={[
{
label: 'value not in options',
value: 'value-not-in-options',
},
]}
mode="multiple"
labelInValue
>
<Option value={1}>1</Option>
<Option value={2}>2</Option>
</Select>,
);
expect(findSelection(wrapper, 0).text()).toEqual('value not in options');
removeSelection(wrapper, 0);
expect(wrapper.find('Selector').props().values.length).toEqual(0);
});

describe('optionLabelProp', () => {
it('basic', () => {
const wrapper = mount(
Expand Down