-
-
Notifications
You must be signed in to change notification settings - Fork 478
fix: onClear triggers onDeselect in multiple mode #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/FunJdqUfP2vUJXFGeJ2FZB48PGKM |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 25 25
Lines 1038 1039 +1
Branches 346 346
=======================================
+ Hits 1033 1034 +1
Misses 4 4
Partials 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
请问改进展如何 |
no effect. it calls onDeselect again. if u have lots of tags selected, it will be called many times. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello, Do you known if this PR can be merged soon? |
Please rebase and add a test case for this. |
done |
When will this optimization be merged? |
@yoyo837 Hi, it would be very cool if you could quickly take a look on this, since it's preventing a lot of people from updating ant design downstream. |
fix #33790