Skip to content

Conversation

madocto
Copy link
Contributor

@madocto madocto commented Mar 21, 2022

fix #33790

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/FunJdqUfP2vUJXFGeJ2FZB48PGKM
✅ Preview: https://select-git-fork-imoctopus-fix-onclear-react-component.vercel.app

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #731 (bd83a02) into master (08757c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          25       25           
  Lines        1038     1039    +1     
  Branches      346      346           
=======================================
+ Hits         1033     1034    +1     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/BaseSelect.tsx 100.00% <ø> (ø)
src/Select.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@SCWR
Copy link

SCWR commented Apr 27, 2022

请问改进展如何

@tiber2013
Copy link

no effect. it calls onDeselect again. if u have lots of tags selected, it will be called many times.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 0:45AM (UTC)

@xrutayisire
Copy link

Hello,

Do you known if this PR can be merged soon?

@yoyo837
Copy link
Member

yoyo837 commented Jun 25, 2022

Please rebase and add a test case for this.

@madocto
Copy link
Contributor Author

madocto commented Jun 28, 2022

done

@leotian
Copy link

leotian commented Aug 15, 2022

When will this optimization be merged?

@ncioj10
Copy link

ncioj10 commented Sep 22, 2022

@yoyo837 Hi, it would be very cool if you could quickly take a look on this, since it's preventing a lot of people from updating ant design downstream.

@yoyo837 yoyo837 merged commit de8f268 into react-component:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onClear triggers onDeselect for all selected values
8 participants