Skip to content

fix: fix marks position #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2020
Merged

fix: fix marks position #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c81580
fix: fix marks position
zuochenxue Feb 28, 2020
f0dfc29
test: add test case
zuochenxue Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/common/Marks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@ const Marks = ({
};

const leftStyle = {
transform: `translateX(-50%)`,
msTransform: `translateX(-50%)`,
[reverse ? 'right' : 'left']: reverse
? `${(point - (min / 4)) / range * 100}%`
: `${(point - min) / range * 100}%`,
transform: `translateX(${reverse ? `50%` : `-50%`})`,
msTransform: `translateX(${reverse ? `50%` : `-50%`})`,
[reverse ? 'right' : 'left']: `${(point - min) / range * 100}%`
};

const style = vertical ? bottomStyle : leftStyle;
Expand Down
6 changes: 6 additions & 0 deletions tests/Slider.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ describe('Slider', () => {
expect(trackStyle.width).toMatch('20%');
});

it('should render reverse Slider with marks correctly', () => {
const marks = {5:'5', 6:'6', 7:'7', 8:'8', 9:'9', 10:'10'};
const wrapper = mount(<Slider value={0} marks={marks} min={5} max={10} reverse />);
expect(wrapper.find('.rc-slider-mark-text').at(0).props().style.right).toMatch('0%');
});

it('should render Slider without handle if value is null', () => {
const wrapper = render(<Slider value={null} />);
expect(wrapper).toMatchSnapshot();
Expand Down