Skip to content

Conversation

ljknight
Copy link

@ljknight ljknight commented Nov 2, 2016

This plugin has been great, we've been using it at my company for a mobile web app. One usability feature that we felt was missing was the ability to swipe to close, instead of only the tap. Hope this works - thanks for your work on this.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 544529f on ljknight:swipe-close into * on react-component:master*.

@ljknight
Copy link
Author

ljknight commented Nov 4, 2016

@silentcloud - based on how these tests are failing it seems like you intentionally set up the swipe to only swipe right or left. Is it ok to have it swipe both ways, or do you think it should be passed in as an option?

@silentcloud
Copy link
Member

@ljknight when left=[] or right=[] , swipe to direction will trigger open() function;

for example:

<Swipe left=[{...}, {...}] onOpen={() => {}} />

when swipe to left direction, open() will be triggered,in fact it should not be triggered

@ljknight
Copy link
Author

ljknight commented Nov 8, 2016

@silentcloud thanks for the reply - I'm not sure I understand what you mean

@silentcloud
Copy link
Member

test

@ljknight
Copy link
Author

ljknight commented Nov 9, 2016

@silentcloud - added an update that won't pass the linter, but it fixes the issue my initial commit didn't take into consideration. let me know what you think.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1416daf on ljknight:swipe-close into * on react-component:master*.

@silentcloud
Copy link
Member

allow swipe to close: 78a5fe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants