refactor: user hammerjs event object #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 6fd225e on backup into ** on master**. |
paranoidjk
changed the title
|
Changes Unknown when pulling 6fd225e on backup into ** on master**. |
|
Changes Unknown when pulling 6fd225e on backup into ** on master**. |
paranoidjk
commented
Aug 15, 2017
| "dependencies": { | ||
| "babel-runtime": "6.x", | ||
| "object.omit": "~2.0.0", | ||
| "omit.js": "^1.0.0", |
|
Changes Unknown when pulling 54db9b8 on backup into ** on master**. |
|
我试了一下，斜着往 11 点钟的方向快速滑，有问题，划出来之后收不回去了 |
paranoidjk
changed the title
|
@silentcloud 再看下？ |
paranoidjk
changed the title
paranoidjk
commented
Aug 16, 2017
| this.needShowRight = isLeft && right!.length > 0; | ||
| this.needShowLeft = isRight && left!.length > 0; | ||
| if (this.left) { | ||
| this.left.style.visibility = this.needShowRight ? 'hidden' : 'visible'; |
There was a problem hiding this comment.
加的这段逻辑是为了解决当往右滑的时候，如果左侧的按钮很多，会导致反而右侧的内容显示出来，左侧的左右边的部分内容被盖住
|
ping @silentcloud |
|
ping @silentcloud |
|
嗯 给你加，PR 我再看看 |
|
@paranoidjk 我先发个 1.4.5-alpha.0 结合 antm 试试 |
paranoidjk
changed the title
paranoidjk
changed the title
|
@silentcloud 之后在 setting 里面把 merge 去掉，只允许 squash and merge 吧 我看不到，可能没权限改 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.