fix: https://github.com/ant-design/ant-design-mobile/issues/1954 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As rc-gesture revert preventDefault in v0.0.19 for tabs+listview issue (ant-design/ant-design-mobile#2589). Then, rc-gesture@v0.0.20 fixed this issue by exposing the `event` as a property of Gesture object, and the Gesture object will be passed as the first parameter when invoked panMove event callback. So, `rc-swipeout` invokes `event.preventDefault()` to prevent scroll event when pan moving.
quentinyang
force-pushed
the
fix-gesture-issue
branch
from
e3c503c to
7d06b6c
Compare
@ziluo 这个 rc-swipeout 和 rmc-tabs 一样都依赖 rc-gesture ，调整下 组件负责人，你和 @quentinyang 一起负责这几个组件 (如果有其他依赖到 rc-gesture 的上层组件 也一起负责掉) ，一起持续的跟踪改动、互相 review 效率高、不容易出问题。 总之，手势相关的都是 非常核心 影响很大 的功能，认真全面地回归测试、OK了你们合并。 |
|
这个后续也把测试用例完善下吧 |
|
CI 挂了，把自己加到 Travis 的邮件通知里面去，合 mr之前关注 ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rc-gesture revert preventDefault in v0.0.19 for tabs+listview issue.
Then, rc-gesture@v0.0.20 fixed the swipe issue by exposing the
eventas a property of Gesture object, and the Gesture object will be passed as the first parameter when invoked panMove event function.So, in this version, to fix it,
rc-swipeoutinvokesevent.preventDefault()to prevent scroll event when pan moving.