Skip to content

refactor: Use rc-util to mini final antd dist size #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 18, 2020

  • 使用 rc-util 库的 useMergedState 做状态管理
  • 移除 autoFocus 相关代码(使用原生逻辑实现)
  • 移除 onMouseUp 调用的 blur 使之更符合无障碍规范
  • 提升覆盖率到 100%
  • Not correct animations ant-design/ant-design#24087 做准备

cc @hengkx

@zombieJ zombieJ requested a review from afc163 May 18, 2020 06:53
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           43        24   -19     
  Branches        12         5    -7     
=========================================
- Hits            43        24   -19     
Impacted Files Coverage Δ
src/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6e547...fc94c31. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented May 18, 2020

我发个 minor 版本,配合去修 ant-design/ant-design#24087

@zombieJ zombieJ merged commit addaf3d into master May 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor branch May 18, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants