[WIP]Tweak should component update #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
changed the title
|
跟 @benjycui 讨论了下，决定直接把 shouldComponentUpdate 去掉。 |
|
这确实是个坑。 |
|
https://github.com/react-component/table/blob/master/src/TableCell.jsx#L15-L17 TableCell 的 shouldComponentUpdate 貌似也同样问题。之前搜索 stateless function 和 pure component 的性能区别时，按 facebook/react#5677 (comment) 的说法貌似 stateless function 的性能都要更好，TableCell 里的优化也确实不一定有效。 |
|
TableCell 的 shouldComponentUpdate 确实没必要加，shouldComponentUpdate 也不是越多越好。 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
发现一个问题，因为现在 columns 允许 render 是一个 function，这导致 TableRow 其实不是一个 pure component，不能用简单的 shouldComponentUpdate 去优化（例子：http://codepen.io/yesmeck/pen/oYNWwM?editors=001 ）。我想后面再看看 Table 里的状态能不能像
currentHoverKey那样抽到 store 里，然后把 shouldComponentUpdate 去掉，现在其实 shouldComponentUpdate 有点鸡肋。