Skip to content

Use computed style #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2018
Merged

Use computed style #139

merged 2 commits into from
Sep 13, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 12, 2018

简单来说就是上层 dom 存在 scale(x) 的时候，内部通过 getBoundingClientRect 计算出的 left 值不正确。所以用 getComputedStyle 自己算了 left / top

kapture 2018-09-12 at 15 48 23

ref: ant-design/ant-design#8992

@zombieJ zombieJ requested review from yesmeck and afc163 September 12, 2018 07:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 71.67% when pulling e1a21bf on recal into ff43f96 on master.

@zombieJ zombieJ merged commit d57dbf0 into master Sep 13, 2018
@zombieJ zombieJ deleted the recal branch September 13, 2018 15:09
@afc163
Copy link
Member

afc163 commented Oct 18, 2018

https://codesandbox.io/s/8108vljxx8

引起了一个自定义 tab margin 时高亮条定位不准的 bug。

@zombieJ
Copy link
Member Author

zombieJ commented Oct 18, 2018

https://codesandbox.io/s/8108vljxx8
引起了一个自定义 tab margin 时高亮条定位不准的 bug。

fixed in 9.4.7: https://codesandbox.io/s/52jl53zplk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

@yesmeck yesmeck Awaiting requested review from yesmeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombieJ @coveralls @afc163