use ResizeObserver to detect size change #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Mar 24, 2019
src/ScrollableTabBarNode.js
Outdated
| } else { | ||
| // fallback to window resize event when ResizeObserver is not available | ||
| this.resizeEvent = addEventListener(window, 'resize', this.debouncedResize); | ||
| } |
There was a problem hiding this comment.
|
@afc163 done. |
|
9.6.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses ResizeObserver to detect size change when it's supported, otherwise fallback to the original method of window resize event.
This should fix ant-design/ant-design#15607 for chrome
Implementing a real resize listener for old browser is just too heavy. I think using ResizeObserver to fix chrome first and wait for other browser to adopt this feature is the best option.