-
-
Notifications
You must be signed in to change notification settings - Fork 244
Use scrollWidth/Height instead of offsetWidth/Height. #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is this fix for? |
Without this patch the sizes used does not take in account the possibility that the measured elements are constrained by a scrollbar, then leading to incorrect presentation. |
Could you provide a reproducible demo for it? |
This is the reproducible demo: After a few uses of + button you will see that the bar does not show navigation buttons. |
Do you confirm the issue and the misuse of offsetWidth/offsetHeight? |
close #84 |
@abramobagnara Yep, i confirmed it'a a bug. Could you rebase master to resolve confict? |
46f7556
to
f26ee57
Compare
Just rebased. |
ping~ |
Just done a new rebase. |
It's used by PC. |
This fixes the computation of size for div.ant-tabs-nav