Skip to content

Conversation

abramobagnara
Copy link

This fixes the computation of size for div.ant-tabs-nav

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 70.295% when pulling 46f7556 on abramobagnara:master into 242b577 on react-component:master.

@afc163
Copy link
Member

afc163 commented Aug 4, 2017

What is this fix for?

@abramobagnara
Copy link
Author

Without this patch the sizes used does not take in account the possibility that the measured elements are constrained by a scrollbar, then leading to incorrect presentation.

@afc163
Copy link
Member

afc163 commented Aug 4, 2017

Could you provide a reproducible demo for it?

@abramobagnara
Copy link
Author

abramobagnara commented Aug 4, 2017

This is the reproducible demo:
https://codepen.io/afc163/pen/eyRONw?editors=1010

After a few uses of + button you will see that the bar does not show navigation buttons.

@abramobagnara
Copy link
Author

Do you confirm the issue and the misuse of offsetWidth/offsetHeight?

@paranoidjk
Copy link
Member

close #84

@paranoidjk
Copy link
Member

@abramobagnara Yep, i confirmed it'a a bug. Could you rebase master to resolve confict?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.815% when pulling f26ee57 on abramobagnara:master into 7f78a16 on react-component:master.

@abramobagnara
Copy link
Author

Just rebased.

@benjycui
Copy link
Member

benjycui commented Oct 9, 2017

ping~

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.407% when pulling 0aa3c63 on abramobagnara:master into 8802ea9 on react-component:master.

@abramobagnara
Copy link
Author

Just done a new rebase.

@paranoidjk
Copy link
Member

paranoidjk commented Oct 9, 2017

@zhang740 Request for review, if it's ok, bump a patch version

It's used by PC.

@afc163 afc163 merged commit a24c7b3 into react-component:master Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants