feat: re-render with new autoSize property. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should i add a test for the feature? @zombieJ |
Yep |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 98.00% 98.02% +0.02%
==========================================
Files 3 3
Lines 150 152 +2
Branches 43 45 +2
==========================================
+ Hits 147 149 +2
Misses 3 3
Continue to review full report at Codecov.
|
|
done. @afc163 |
afc163
reviewed
Dec 11, 2021
src/ResizableTextArea.tsx
Outdated
| // Re-render with the new content then recalculate the height as required. | ||
| if (prevProps.value !== this.props.value) { | ||
| // Re-render with the new content or new autoSize property then recalculate the height as required. | ||
| if ((prevProps.value !== this.props.value) || (prevProps.autoSize !== this.props.autoSize)) { |
There was a problem hiding this comment.
<TexArea autoSize={{ minRows: 1, maxRows: 6 }} />这样写的话，这个比较会永远不相等，最好做一层浅比较。
There was a problem hiding this comment.
是的，之前只考虑了值有变化的情况下就会重新计算高度。如果要下沉一层再做浅比较，是不是需要考虑autoSize 为boolean值的情况？
|
什么时候发布... |
1 task
|
@losgif 麻烦看下上面这个问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support to issue(ant-design/ant-design#33202)
close ant-design/ant-design#33202