Update onChange typing to include default type #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in the README, the default value for
value
isnull
, even though normally it will be of typeMoment
.However, the
onChange
handler type is specified to always return a Moment:I have updated the type to be a union type of
Moment | null
which properly handles the default value case returning fromonChange
.Does any additional work need to be done to push these changes to
@types/rc-time-picker
? That is currently what I am using.