Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 22, 2020

fix ant-design/ant-design#23079

v4 错误的把 treeNodeLabelProp 作用到了 Tree 中,它应该只作用到 option values 里

虽然是个 bug 但是也是个 breaking change,要发 minor

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tree-select/hkij4sicj
✅ Preview: https://tree-select-git-fix-options.react-component.vercel.app

@zombieJ zombieJ requested a review from afc163 July 22, 2020 09:56
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          523       524    +1     
  Branches       156       155    -1     
=========================================
+ Hits           523       524    +1     
Impacted Files Coverage Δ
src/TreeSelect.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd486c...a3d2762. Read the comment docs.

@zombieJ zombieJ merged commit 9de5d2f into master Jul 22, 2020
@zombieJ zombieJ deleted the fix-options branch July 22, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TreeSelect的title与treeNodeLabelProp

2 participants