Skip to content

Conversation

shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Oct 17, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/trigger/e2mwtm3cq
🌍 Preview: https://trigger-git-fix-ts-type.react-component.now.sh

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files           7        7           
  Lines         460      460           
  Branches      122      122           
=======================================
  Hits          385      385           
  Misses         75       75
Impacted Files Coverage Δ
src/index.tsx 79.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f722c2...01658de. Read the comment docs.

@zombieJ zombieJ merged commit 698a27c into master Oct 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-ts-type branch October 17, 2019 13:17
@zombieJ
Copy link
Member

zombieJ commented Oct 17, 2019

OPS. Trigger children should be React.Element. Reverted:
截屏2019-10-17下午9 24 13

zombieJ added a commit that referenced this pull request Oct 17, 2019
@zombieJ zombieJ mentioned this pull request Oct 17, 2019
zombieJ added a commit that referenced this pull request Oct 17, 2019
@shaodahong
Copy link
Member Author

This children if React.Element type, Then use rc-trigger wrapper component children also is React.Element

@zombieJ
Copy link
Member

zombieJ commented Oct 17, 2019

Yes. Should be ReactElement since it need children's props.

@shaodahong
Copy link
Member Author

ok,my fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants