Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 6, 2020

@vercel
Copy link

vercel bot commented Mar 6, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/trigger/7xzjubi2l
✅ Preview: https://trigger-git-check-ref.react-component.now.sh

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #174 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage    85.6%   85.68%   +0.08%     
==========================================
  Files           7        7              
  Lines         500      503       +3     
  Branches      144      145       +1     
==========================================
+ Hits          428      431       +3     
  Misses         72       72
Impacted Files Coverage Δ
src/index.tsx 82.12% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428071e...8116e30. Read the comment docs.

@zombieJ zombieJ merged commit 858968c into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the check-ref branch March 6, 2020 04:25
@AshoneA
Copy link

AshoneA commented Mar 6, 2020

原来获取 child 的 ref 只是为了保持外界 ref 调用一致吗?我还以为跟 pop 的位置有关系。👍

@zombieJ
Copy link
Member Author

zombieJ commented Mar 6, 2020

原本实现是 findDOMNode 严格模式会报错,所以改成了 ref。但是实际上很多场景都不适用,希望 React 快点出替代方案。

@AshoneA
Copy link

AshoneA commented Mar 6, 2020

那个 Fragment 的提案被关闭了... 感觉还得再等好一会儿才能有替代方案。

@zombieJ
Copy link
Member Author

zombieJ commented Mar 6, 2020

嗯,既不推荐又不给替代方案比较蛋疼。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems use Tooltip in every function component without forwardRef report error
2 participants