fix: Motion state record #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
怎么发现的... |
afc163
approved these changes
Jul 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 85.74% 85.43% -0.31%
==========================================
Files 7 7
Lines 505 508 +3
Branches 146 143 -3
==========================================
+ Hits 433 434 +1
- Misses 72 74 +2
Continue to review full report at Codecov.
|
|
语雀同学报的 |
|
语雀那个问题是突然出现的，而且他们应该还用的是 antd 3.x，可能不是这个问题。 |
|
他们最近升级完 v4 了，只是为了保持品牌一致性所以一些 design token 改成了 v3 的。组件已经是新的了。 |
07akioni
approved these changes
Jul 29, 2020
|
#189 先 revert 掉，我看看是啥原因 |
zombieJ
added a commit
that referenced
this pull request
Jul 29, 2020
|
onMotionEvent 死循环了，先回滚再 patch 一个版本 |
zombieJ
added a commit
that referenced
this pull request
Jul 29, 2020
* fix: Motion state record * update test case
zombieJ
added a commit
that referenced
this pull request
Jul 29, 2020
* fix: Motion state record (#188) * fix: Motion state record * update test case * fix: Motion state record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
横向快速移动鼠标，tooltip 会不消失：
https://codesandbox.io/s/beautiful-faraday-zfmgw?file=/index.js
原因在于 setState 是异步操作被 batch update，导致 motion 没有启动就被结束，而 Trigger 层以为已经触发了 motion 就继续执行锁逻辑导致 PopupInner 弹出后没人管的状态。
这个 fix 添加了一个额外的事件监听用于检查是否真的在进行动画。可能会有新 bug，随遇随修。