Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 16, 2023

visibleFirst 模式下,会优先在视窗区域展示,其次降级为滚动区域展示。

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #383 (716821c) into master (1bb406c) will increase coverage by 0.34%.
The diff coverage is 100.00%.

❗ Current head 716821c differs from pull request most recent head d30fde0. Consider uploading reports for the commit d30fde0 to get more accurate results

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   96.25%   96.60%   +0.34%     
==========================================
  Files          12       12              
  Lines         668      706      +38     
  Branches      187      208      +21     
==========================================
+ Hits          643      682      +39     
+ Misses         25       24       -1     
Impacted Files Coverage Δ
src/index.tsx 95.56% <ø> (ø)
src/hooks/useAlign.ts 96.37% <100.00%> (+0.99%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163
Copy link
Member

afc163 commented May 16, 2023

为啥加这个,antd 里用哪个?

@zombieJ zombieJ merged commit 062842d into master May 16, 2023
@zombieJ zombieJ deleted the fix-visible branch May 16, 2023 05:41
@zombieJ
Copy link
Member Author

zombieJ commented May 16, 2023

为啥加这个,antd 里用哪个?

陆沉的那个 case,visible 区域 和 scroll 区域重叠的情况,scroll 展示全 & visible 看得多,这个时候应该选用 scroll。antd 里先给 Popover 替换一下,然后看效果再全部替换掉。

@zombieJ
Copy link
Member Author

zombieJ commented May 16, 2023

ref ant-design/ant-design#42392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants