Skip to content

fix: Click window should not immediately close if open is first time trigger #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 23, 2023

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #386 (d43d0cc) into master (783e8b4) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head d43d0cc differs from pull request most recent head 98c2c91. Consider uploading reports for the commit 98c2c91 to get more accurate results

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   96.60%   96.67%   +0.07%     
==========================================
  Files          12       13       +1     
  Lines         706      722      +16     
  Branches      208      213       +5     
==========================================
+ Hits          682      698      +16     
  Misses         24       24              
Impacted Files Coverage Δ
src/hooks/useWinClick.ts 100.00% <100.00%> (ø)
src/index.tsx 94.97% <100.00%> (-0.60%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit cc6b63d into master May 23, 2023
@zombieJ zombieJ deleted the fix-click branch May 23, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown glitches when usingtrigger={['click']} and triggering the open state from some other click
1 participant