Skip to content

chore: rm one more dom #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

chore: rm one more dom #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
905090c
chore: rm one more dom
zombieJ Sep 18, 2025
1e8ef46
fix: lint
zombieJ Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions src/UniqueProvider/MotionContent.tsx
View file
Open in desktop

This file was deleted.

12 changes: 1 addition & 11 deletions src/UniqueProvider/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import useTargetState from './useTargetState';
import { isDOM } from '@rc-component/util/lib/Dom/findDOMNode';
import FloatBg from './FloatBg';
import classNames from 'classnames';
import MotionContent from './MotionContent';
import { getAlignPopupClassName } from '../util';

export interface UniqueProviderProps {
Expand Down Expand Up @@ -43,8 +42,6 @@ const UniqueProvider = ({ children }: UniqueProviderProps) => {
});

// ========================== Register ==========================
const [popupId, setPopupId] = React.useState(0);

// Store the isOpen function from the latest show call
const isOpenRef = React.useRef<(() => boolean) | null>(null);

Expand All @@ -56,9 +53,6 @@ const UniqueProvider = ({ children }: UniqueProviderProps) => {
isOpenRef.current = isOpen;

delayInvoke(() => {
if (showOptions.id !== options?.id) {
setPopupId((i) => i + 1);
}
trigger(showOptions);
}, showOptions.delay);
},
Expand Down Expand Up @@ -172,11 +166,7 @@ const UniqueProvider = ({ children }: UniqueProviderProps) => {
ref={setPopupRef}
portal={Portal}
prefixCls={prefixCls}
popup={
<MotionContent prefixCls={prefixCls} key={popupId}>
{options.popup}
</MotionContent>
}
popup={options.popup}
className={classNames(
options.popupClassName,
alignedClassName,
Expand Down
Loading