refactor: Portal render sync #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaodahong
reviewed
Sep 23, 2020
shaodahong
reviewed
Sep 23, 2020
shaodahong
reviewed
Sep 23, 2020
| @@ -40,8 +40,42 @@ const getParent = getContainer => { | |||
| return document.body; | |||
| }; | |||
|
|
|||
| class PortalWrapper extends React.Component { | |||
| constructor(props) { | |||
| export type GetContainer = string | HTMLElement | (() => HTMLElement); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
这边的支持的更多一些：
Line 22 in 69046a6
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原本通过
componentDidMount创建div来放节点，导致即便配置forceRender，第一次useEffect还是没有东西。改成同步创建，帮忙检查一下。@afc163 @shaodahong
ref ant-design/ant-design#26545