-
Notifications
You must be signed in to change notification settings - Fork 191
feat: getContainer改变后更新Portal的容器 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
binyellow
wants to merge
6
commits into
react-component:master
Choose a base branch
from
binyellow:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fe8155a
feat: getContainer改变后更新Portal的容器
6abdcb5
feat: 添加测试用例和解决ci报错
ba941f3
feat: 修改container命名,rmoveContainer修改
binyellow dd2a921
feat: 去除多余依赖,修改测试用例,判断父容器变化了
binyellow 917b036
feat: 调整测试用例
binyellow e7e5b46
feat: 更新container先移除上次的结点
binyellow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import React from 'react'; | ||
import { mount } from 'enzyme'; | ||
import PortalWrapper from '../src/PortalWrapper'; | ||
|
||
describe('container', () => { | ||
let div1; | ||
let div2; | ||
beforeAll(() => { | ||
div1 = document.createElement('div'); | ||
div1.id = 'dom1'; | ||
div2 = document.createElement('div'); | ||
div2.id = 'dom2'; | ||
document.body.appendChild(div1); | ||
document.body.appendChild(div2); | ||
}); | ||
afterAll(() => { | ||
document.body.removeChild(div1); | ||
document.body.removeChild(div2); | ||
}); | ||
it('Same function returns different DOM', async () => { | ||
const wrapper = mount( | ||
<PortalWrapper | ||
visible | ||
getContainer={() => document.getElementById('dom1')} | ||
> | ||
{() => <div id="children">Content</div>} | ||
</PortalWrapper>, | ||
); | ||
|
||
expect(document.querySelector('#dom1 #children')).not.toBeNull(); | ||
|
||
wrapper.setProps({ getContainer: () => document.getElementById('dom2') }); | ||
|
||
expect(document.querySelector('#dom1 #children')).toBeNull(); | ||
expect(document.querySelector('#dom2 #children')).not.toBeNull(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果要这么写的话,应该要把上次的结点移除掉,不然其实会有 bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
恩 是的,测到了。
关于更新的问题,其实PortalWrapper里面也做了相应的处理,在getDerivedStateFromProps中做了判断和移除操作,只不过Portal内没更新,Portal不做更新复用之前的container在性能上确实会好点,看你们判断吧