Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 8, 2019

Done

Adjust exist algorithm to support basic virtual scroll.

  • Use ref to measure item height firstly.
  • Downgrade to findDOMNode if not a real DOM element.

Next

  • Animation support
  • Scroll to support

@zombieJ zombieJ requested a review from afc163 July 8, 2019 11:35
@vercel
Copy link

vercel bot commented Jul 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-virtual-list-git-basic.react-component.now.sh

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3e391b6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##             master   #1   +/-   ##
=====================================
  Coverage          ?   0%           
=====================================
  Files             ?    3           
  Lines             ?   71           
  Branches          ?   11           
=====================================
  Hits              ?    0           
  Misses            ?   71           
  Partials          ?    0
Impacted Files Coverage Δ
src/Filler.tsx 0% <0%> (ø)
src/List.tsx 0% <0%> (ø)
src/util.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e391b6...87e1c5e. Read the comment docs.

@zombieJ zombieJ merged commit bf9d7ef into master Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the basic branch July 8, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants