Skip to content

Conversation

nodkz
Copy link

@nodkz nodkz commented Aug 25, 2020

Fix SSR

vpc-admin: [dev] ReferenceError: navigator is not defined
vpc-admin: [dev]     at Object.<anonymous> (/vpc/apps/admin/node_modules/rc-virtual-list/lib/utils/isFirefox.js:7:28)
vpc-admin: [dev]     at Module._compile (internal/modules/cjs/loader.js:778:30)
vpc-admin: [dev]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
vpc-admin: [dev]     at Module.load (internal/modules/cjs/loader.js:653:32)
vpc-admin: [dev]     at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
vpc-admin: [dev]     at Function.Module._load (internal/modules/cjs/loader.js:585:3)
vpc-admin: [dev]     at Module.require (internal/modules/cjs/loader.js:692:17)
vpc-admin: [dev]     at require (internal/modules/cjs/helpers.js:25:18)
vpc-admin: [dev]     at Object.<anonymous> (//vpc/apps/admin/node_modules/rc-virtual-list/lib/hooks/useFrameWheel.js:12:41)
vpc-admin: [dev]     at Module._compile (internal/modules/cjs/loader.js:778:30)

@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/virtual-list/iwsyrvla2
✅ Preview: https://virtual-list-git-fork-nodkz-patch-1.react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          357       357           
  Branches        64        64           
=========================================
  Hits           357       357           
Impacted Files Coverage Δ
src/utils/isFirefox.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c898cb...9d2a5fe. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Aug 25, 2020

Thanks for PR. We are working on this at same time : )
74525e6

@zombieJ zombieJ closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants