Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 21, 2019

In rc-select, we should support open to scroll to the active item:

listRef.current.scrollTo({ index: 233, align: 'auto' });

Support align:

  • auto
  • top
  • bottom

@vercel
Copy link

vercel bot commented Aug 21, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-virtual-list-git-scroll-to.react-component.now.sh

@zombieJ zombieJ requested a review from afc163 August 21, 2019 08:41
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #8      +/-   ##
========================================
+ Coverage   99.65%   100%   +0.34%     
========================================
  Files           5      5              
  Lines         289    343      +54     
  Branches       63     85      +22     
========================================
+ Hits          288    343      +55     
+ Misses          1      0       -1
Impacted Files Coverage Δ
src/List.tsx 100% <100%> (ø) ⬆️
src/utils/algorithmUtil.ts 100% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2739b9b...18313a7. Read the comment docs.

@zombieJ zombieJ merged commit 1d883a8 into master Aug 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the scroll-to branch August 21, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant