Skip to content

Conversation

gion
Copy link
Contributor

@gion gion commented Oct 10, 2018

I know this has been issued before (#24), but the problem still exists.
Inspired from #48 (btw, thanks @leejaen 👍), I want to submit this PR to solve the safari related issues I'm having.

@coveralls
Copy link

coveralls commented Oct 10, 2018

Coverage Status

Coverage increased (+0.4%) to 82.979% when pulling 5d37381 on gion:fix/safari-download into dbc0467 on abdennour:master.

@abdennour abdennour requested a review from mriccid October 11, 2018 19:26
@mccabemj
Copy link
Collaborator

@gion can you remove the debugger line in core.js and I'll test/merge this PR

@gion
Copy link
Contributor Author

gion commented Oct 12, 2018

@mccabemj , sorry for that [insert embarrased emoji here].
I pushed another commit that removes the debugger.
Thanks!

@mccabemj mccabemj requested review from mccabemj and removed request for mriccid October 16, 2018 12:12
@mccabemj mccabemj merged commit 27a6f80 into react-csv:master Oct 16, 2018
@gion
Copy link
Contributor Author

gion commented Oct 16, 2018

Thanks! 👍
@mccabemj @abdennour Do you happen to know when this patch is going to be released on npm?

@mccabemj
Copy link
Collaborator

@gion just published it now. Thanks for your contribution!

@gion
Copy link
Contributor Author

gion commented Oct 16, 2018

Wow, that was fast.
Thanks!
Keep up the good work ;)

@leejaen
Copy link

leejaen commented Oct 16, 2018

GREAT JOB!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants