Lib Upgrades (WIP) (#1149)

* chore: upgrade husky, add commitlint verification

Additionally, upgrading prettier and npm-run-all

* remove @types/node dependency

* chore: add commitlint config

* chore: upgrade webpack, webpack-dev-server, webpack-cli

* chore: upgrade lodash

* chore: upgrade shallowequal

* chore: remove @types/shallowequal dependency, since it was unused

* chore: upgrade webpack loaders, babel

* chore: upgrade lerna

* chore: upgrade jest

* chore: upgrade runtime version of react

* chore: enable strict-mode in docsite

* remove autobind-decorator in favor of class-bind member semantics

* chore: use suspense for loading examples

* chore: pin the version of react to match what's in react-dom

* chore: upgrade react-dom version

* chore: remove less, replace with styled-components

* chore: update redux

* chore: upgrade typescript & tooling

* chore: remove suspense from static site generation, as it uses SSR

* chore: use gh-pages module to manage docsite deployment

* chore: remove less file

Author: darthtrevino

commitlint.config.js

@@ -0,0 +1 @@
+module.exports = { extends: ['@commitlint/config-conventional'] }

package.json

@@ -41,7 +41,7 @@
 		"lint":
 			"tslint \"packages/**/*.{ts,tsx}\" -e \"**/{lib,node_modules}/**\"",
 		"test_modules": "lerna run test --stream",
-		"publish_docs": "./scripts/publishDocumentation.sh",
+		"publish_docs": "lerna run publish --scope react-dnd-documentation",
 		"test": "run-s lint build test_modules jest:cov",
 		"prettify":
 			"prettier 'packages/*/**/*.js' 'examples/**/*.js' 'site/**/*.js'",
@@ -50,19 +50,28 @@
 		"start": "lerna run --parallel --stream start",
     "watch": "lerna run --parallel --stream watch"
 	},
+	"husky": {
+		"hooks": {
+			"pre-commit": "lint-staged",
+			"pre-publish": "npm test",
+			"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
+		}
+	},
 	"devDependencies": {
-		"@types/jest": "^22.2.3",
-		"husky": "^0.14.3",
-		"jest": "^23.0.0-beta.3r",
-		"jest-environment-jsdom": "^22.4.3",
-		"lerna": "^2.9.0",
-		"lint-staged": "^4.2.3",
-		"npm-run-all": "^4.1.2",
-		"prettier": "^1.11.1",
-		"ts-jest": "^22.4.4",
-		"tslint": "^5.9.1",
-		"tslint-config-prettier": "^1.12.0",
-		"tslint-react": "^3.5.1"
+		"@commitlint/cli": "^7.2.1",
+		"@commitlint/config-conventional": "^7.1.2",
+		"@types/jest": "^23.3.8",
+		"husky": "^1.1.2",
+		"jest": "^23.6.0",
+		"jest-environment-jsdom": "^23.4.0",
+		"lerna": "^3.4.3",
+		"lint-staged": "^7.3.0",
+		"npm-run-all": "^4.1.3",
+		"prettier": "^1.14.3",
+		"ts-jest": "^23.10.4",
+		"tslint": "^5.11.0",
+		"tslint-config-prettier": "^1.15.0",
+		"tslint-react": "~3.6.0"
 	},
 	"jest": {
 		"moduleFileExtensions": ["ts", "tsx", "js", "jsx"],
@@ -100,7 +109,6 @@
     "nohoist": [
       "**/@types/*",
       "**/hoist-non-react-statics",
-      "**/autobind-decorator",
       "**/redux"
     ]
 	}

packages/dnd-core/package.json

@@ -19,13 +19,12 @@
 	"dependencies": {
 		"asap": "^2.0.6",
 		"invariant": "^2.2.4",
-		"lodash": "^4.17.10",
-		"redux": "^4.0.0"
+		"lodash": "^4.17.11",
+		"redux": "^4.0.1"
 	},
 	"devDependencies": {
-		"@types/node": "10.3.2",
-		"npm-run-all": "^4.1.2",
+		"npm-run-all": "^4.1.3",
 		"rimraf": "^2.6.2",
-		"typescript": "^2.8.1"
+		"typescript": "^3.1.3"
 	}
 }

packages/dnd-core/src/DragDropMonitorImpl.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import { Store } from 'redux'
 import matchesType from './utils/matchesType'
 import {

packages/dnd-core/src/HandlerRegistryImpl.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import { Store } from 'redux'
 import {
 	addSource,
@@ -51,7 +53,10 @@ function mapContainsValue<T>(map: Map<string, T>, searchValue: T) {
 	const entries = map.entries()
 	let isDone = false
 	do {
-		const { done, value: [, value] } = entries.next()
+		const {
+			done,
+			value: [, value],
+		} = entries.next()
 		if (value === searchValue) {
 			return true
 		}

packages/dnd-core/src/__tests__/DragDropManager.spec.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import createTestBackend, { TestBackend } from 'react-dnd-test-backend'
 import * as Types from './types'
 import { NormalSource, NonDraggableSource, BadItemSource } from './sources'
@@ -9,7 +11,7 @@ import {
 	TransformResultTarget,
 } from './targets'
 import DragDropManagerImpl from '../DragDropManagerImpl'
-import { DragDropManager, Backend, HandlerRegistry } from '../interfaces'
+import { DragDropManager, HandlerRegistry } from '../interfaces'
 const isString = require('lodash/isString')
 
 describe('DragDropManager', () => {
@@ -306,7 +308,7 @@ describe('DragDropManager', () => {
 
 			it('throws in endDrag() if it is called outside a drag operation', () => {
 				const source = new NormalSource()
-				const sourceId = registry.addSource(Types.FOO, source)
+				registry.addSource(Types.FOO, source)
 				expect(() => backend.simulateEndDrag()).toThrow()
 			})
 

packages/dnd-core/src/actions/dragDrop.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import {
 	Action,
 	DragDropManager,

packages/dnd-core/src/contracts.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import { DragSource, DropTarget, Identifier } from './interfaces'
 const invariant = require('invariant')
 

packages/dnd-core/src/reducers/dirtyHandlerIds.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import {
 	BEGIN_DRAG,
 	PUBLISH_DRAG_SOURCE,

packages/dnd-core/src/reducers/dragOperation.ts

@@ -1,3 +1,5 @@
+declare var require: any
+
 import {
 	BEGIN_DRAG,
 	PUBLISH_DRAG_SOURCE,