Have build in repo

[cjblomqvist]

As a windows user, there are complications getting the repo to build, which is really unfortunate because I really just wanted to get the compiled webpack file. It would be lovely if the repo consisted (at least with every release) had a build dir with the webpack (and any other files builded).

Should be very easy to achieve. Looks like a great component for React btw!

[mzabriskie]

I totally agree. I have plans to include a dist/ folder with built source. I will also be releasing to bower. Give me until the end of the week and I should have something for you.

[cjblomqvist]

Thanks for quick response! Also, I noticed that the bundle is about 1.8mb, which seems quite strange to me. Just something that might be nice to be aware of. For example, it seems test and example code is included in the bundle.

[cjblomqvist]

Some pointers that I think might help newcomers (that I find after digging around a bit):

• The webpack currently compiles the example. I'd expect a compiled file which I can just add through a script-tag. This was really confusing and I totally missed that in webpack.config.js when I tried to figure out what was wrong.
• The build instructions doesn't work in Windows (it assumes shell script exists). Should be fairly straight forward to convert it to be run by node instead and make it cross platform compatible I'd guess?
• The size of the webpack is quite big. I tried to see if it'd help a lot to remove non-production code - it doesn't seem to help that much. However, the --devtool inline-source-map default option causes 1 extra mb of (non-compiled). Might not be optimal from a production perspective. One can also add something along the following lines to make the non-production stuff go away (at least when minifying).

var DefinePlugin = require('webpack').DefinePlugin;

// other code ...

plugins: [
    new DefinePlugin({
      'process.env': {
        'NODE_ENV': JSON.stringify(process.env.NODE_ENV ? process.env.NODE_ENV : '')
      }
    })
  ]

A suggestion might be to auto-compile one production ready version and one developer ready version.

Anyway, just some hopefully helpful thoughts that hopefully can save some time from you.

[cjblomqvist]

Hmm, I guess it doesn't work to use webpack that way, at least not without some hacking: https://github.com/webpack/docs/wiki/webpack-for-browserify-users#external-requires

[cjblomqvist]

Hmm, after a closer look, it should be easily configured by using for example something like this:

output: {
filename: './build/bundle.js',
library: "ReactDraggable",
libraryTarget: "var"
},

[mzabriskie]

@cjblomqvist I just released version 0.2.0 which includes dist/ when using npm. I have also registered the package with bower. So either way you are installing your use case should be supported.

[cjblomqvist]

Very nice work - solves all my previous "issues". Much appreciated!