Improved handling of document body scale transformations #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaled using a css transform (eg. transform: scale(0.5);)
|
This is a very specific hack that will only handle the specific case where Therefore I cannot accept it - it is too specific. It would be better if this could handle any parent scale, or if a callback were attached to modify the width and height so that this could be implemented in the application but outside of That said, thank you very much for the contribution and I hope you have the time for a more general solution. |
This was referenced Feb 17, 2017
Closed
|
I had originally done this with a property. Would passing in a "scale" property be acceptable? |
|
I think a callback would be better; that way users can add any custom behavior they like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added ability to use react-resizable when the document body has been scaled using a css transform (eg. transform: scale(0.5);)
This fixes #52 and fulfills the requirements for react-grid-layout/react-grid-layout#486