Skip to content

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jan 11, 2022

How does this PR fix the problem?

Added extra parameter that allows to enable/disable observation dynamically.

Checklist

  • Have you read contribution guideline?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Have you run the tests locally to confirm they pass?

Added extra parameter that allows to enable/disable observation
dynamically.

#fix: #523
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #573 (4b649ca) into master (66655b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines          778       780    +2     
  Branches       140       144    +4     
=========================================
+ Hits           778       780    +2     
Impacted Files Coverage Δ
src/useMeasure/useMeasure.ts 100.00% <100.00%> (ø)
src/useResizeObserver/useResizeObserver.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe6f8d...4b649ca. Read the comment docs.

@xobotyi xobotyi merged commit 4c6f074 into master Jan 11, 2022
@xobotyi xobotyi deleted the implement-523 branch January 11, 2022 07:49
github-actions bot pushed a commit that referenced this pull request Jan 11, 2022
# [12.1.0](v12.0.3...v12.1.0) (2022-01-11)

### Features

* **useMeasure,useResizeObserver:** ability yo disable observation ([#573](#573)) ([4c6f074](4c6f074)), closes [#523](#523)
@xobotyi
Copy link
Contributor Author

xobotyi commented Jan 11, 2022

🎉 This PR is included in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant