Skip to content

Update AsyncStorage.js #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2019
Merged

Update AsyncStorage.js #268

merged 2 commits into from
Dec 14, 2019

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Dec 13, 2019

Summary:

AsyncStorage.multiRemove(['a']);

/*
[AsyncStorage] The value for key "a" is not a string. This can lead to unexpected behavior/errors. Consider stringifying it.
Passed value: 0
Passed key: a
*/

Fixed #267

Test Plan:

AsyncStorage.multiRemove(['a']);

krizzu
krizzu requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

Only small change to be made, and we're good to go.

@retyui retyui requested a review from krizzu December 13, 2019 17:57
@krizzu
Copy link
Member

krizzu commented Dec 14, 2019

Thanks!

@krizzu krizzu merged commit 3e7fdf3 into react-native-async-storage:LEGACY Dec 14, 2019
@losh11 losh11 mentioned this pull request Dec 28, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu Awaiting requested review from krizzu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong the value is not a string warning on multiRemove
2 participants
@retyui @krizzu