fix: Web compatibility #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
May 11, 2020
There was a problem hiding this comment.
Since you're renaming files, I'd suggest to use *.native.js and *.js instead of *.js and *.web.js to have files for native and web. This is because metro supports *.native.js by default, but webpack doesn't support *.web.js by default (I think it used to but doesn't anymore). So this will be one less configuration to do.
mdjastrzebski
approved these changes
May 13, 2020
This was referenced May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since we target web, Async Storage needs to be available to use by CRA too.
What has been done:
src/commonjs/es modulescompatible bundlescommonjsmodule and type-less (removed Flow)Test Plan:
Green CI.