Skip to content

Conversation

dpnolte
Copy link
Contributor

@dpnolte dpnolte commented Mar 24, 2020

Summary

For the typescript target, this PR aims to add an option to specify a path to tsc. We are using bob in a workspace setup. With this option, we can resolve tsc's path to the workspace root's node modules so that not the global tsc is being used.

Test Plan

I've tested this fork with our setup and it works.

Checklist

  • [X ] I have tested this on a device and a simulator
  • I added the documentation in README.md
  • [N/A ] I mentioned this change in CHANGELOG.md
  • [ X] I updated the typed files (TS and Flow)
  • [N/A ] I added a sample use of the API in the example project (example/App.js)

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR. I left 2 small comments

@dpnolte
Copy link
Contributor Author

dpnolte commented Mar 28, 2020

Thanks for your feedback! I've incorporated your comments in the latest commit.
Also, as a fellow react-native developer, I'd like to say thank you for all the work you're putting into the react native community 🥇

@dpnolte
Copy link
Contributor Author

dpnolte commented Mar 28, 2020

i've also updated the error/warning messages

Copy link
Contributor

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of suggestions.

Co-authored-by: James George <jamesgeorge998001@gmail.com>
@satya164 satya164 changed the title Feat - typescript - add option to specify tsc path feat: add option to specify tsc path May 7, 2020
@satya164 satya164 merged commit 05a53a5 into callstack:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants