Remove dependency on existence of isNewArchitectureEnabled()

[erksch]

I found that applyNativeModulesAppBuildGradle in native_modules.gradle makes assumptions about the isNewArchitectureEnabled function being defined somehow, which in a normal setup is defined in the app/build.gradle of RN boilerplate. Although we may know the setup in which native_modules.gradle will be included there should be no such assumptions in the gradle script.

We use a build.gradle.kts instead of build.gradle which as far as I know does not allow for the magic exposure of the isNewArchitectureEnabled function to the native_modules.gradle script.

Replacing the function with a direct for "newArchEnabled".

Fixes #1697

[thymikee]

@cortinico could you advise here please?

[erksch]

Another option would be to directly read newArchEnabled from the project properties.

[cortinico]

Another option would be to directly read newArchEnabled from the project properties.

This is the preferred approach (and is actually the most robust one). The CLI is currently assuming the isNewArchitectureEnabled is defined, which could not be the case everywhere.
Reading the Gradle property should be the preferred way here.

[erksch]

Ok I'll implement that! It then will also not be a breaking change.

[thymikee]

Thanks @cortinico @erksch !

[adamTrz]

Think this should also fix #1697 💪

[erksch]

@adamTrz not exactly a fix :D people should still configure their build.gradle correctly when updating. But now at least the native_modules.gradle script will not care.

[adamTrz]

@adamTrz not exactly a fix :D people should still configure their build.gradle correctly when updating. But now at least the native_modules.gradle script will not care.

Yeah, but at least it shouldn't crash the build :)

[thymikee]

Published v9.0.1 with this. Please check the upgrade guide for the @react-native-community/cli or invalidate the whole lock file.