Add support for explicit cmakeListsPath in react-native.config.js #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
requested review from
Esemesek,
grabbou and
thymikee
as code owners
thymikee
reviewed
Sep 7, 2022
docs/platforms.md
Outdated
| libraryName?: string | null; | ||
| componentDescriptors?: string[] | null; | ||
| androidMkPath?: string | null; | ||
| cmakePath?: string | null; |
There was a problem hiding this comment.
Do you think cmakeListsPath would make more sense due to being more explicit? I'm good with both, but have a slight favor for explicitness
thymikee
reviewed
Sep 7, 2022
thymikee
reviewed
Sep 7, 2022
Yup better be explicit |
thymikee
changed the title
thymikee
approved these changes
Sep 7, 2022
|
Released 9.1.0 with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Power library authors might want to specify a custom CMake path. Currently we've been reusing the
androidMkPathconfig key assuming that the CMake file would be in the same folder (which is a sound assumption). However we should be more precise here and allow users to specify a customcmakeListsPathif they want.Test Plan:
@thymikee not sure how can we test this as the change is touching several files.