Revert "chore(e2e): check for undefined code before printing fail" #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 2204d35.
|
Let's revert this for now to debug Windows failures, in future I'll try to rewrite this part of codebase (bump |
szymonrybczak
force-pushed
the
revert-2061-e2e-helper-undefined
branch
3 times, most recently
from
e86a176 to
449438b
Compare
|
Instead of commenting the code, let's revert it properly. You can reapply the commit later with git anyway (I guess two things got mixed here) |
szymonrybczak
force-pushed
the
revert-2061-e2e-helper-undefined
branch
from
449438b to
0fc5376
Compare
Yeah, done. I just wanted to debug the situation with Windows failure, it is hard to reproduce (that's why I commented code because I wanted to check is it related to creating git repository, fortunately not) 😅 |
adamTrz
approved these changes
Nov 3, 2023
TMisiukiewicz
approved these changes
Nov 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2061