Skip to content

feat(ios): sort simulators to get iOS first #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat(ios): sort simulators to get iOS first #2153

merged 2 commits into from
Nov 2, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Closes #2143

In this PR I added sorting simulators to first run iOS ones, to avoid situation like this one.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

thymikee
thymikee reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Let's add a test for that please

@szymonrybczak
Copy link
Collaborator Author

Let's add a test for that please

Done ✅

@szymonrybczak szymonrybczak merged commit fbed2ed into main Nov 2, 2023
@szymonrybczak szymonrybczak deleted the feat/sort-simulators branch November 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@adamTrz adamTrz adamTrz approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: unknown option '--simulator'
3 participants
@szymonrybczak @thymikee @adamTrz